martin-g commented on code in PR #579:
URL: https://github.com/apache/avro-rs/pull/579#discussion_r3578361693
##########
avro/src/types.rs:
##########
@@ -729,8 +790,8 @@ impl Value {
}) => self.resolve_enum(symbols, default, field_default),
Schema::Array(inner) => self.resolve_array(&inner.items, names,
enclosing_namespace),
Schema::Map(inner) => self.resolve_map(&inner.types, names,
enclosing_namespace),
- Schema::Record(RecordSchema { fields, .. }) => {
- self.resolve_record(fields, names, enclosing_namespace)
+ Schema::Record(RecordSchema { fields, name, .. }) => {
+ self.resolve_record(fields, names,
name.namespace().or(enclosing_namespace))
Review Comment:
Continuation of
https://github.com/apache/avro-rs/pull/579/changes#r3578241892:
because of the change at
https://github.com/apache/avro-rs/pull/579/changes#diff-9ce454ff2db8b0477e609ee586622825012be35efe856246c9ec0de5936b3879L682-R717
the `enclosing_namespace` will be `None` here and won't help much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
