Kriskras99 commented on code in PR #579:
URL: https://github.com/apache/avro-rs/pull/579#discussion_r3578379095
##########
avro/src/types.rs:
##########
@@ -729,8 +790,8 @@ impl Value {
}) => self.resolve_enum(symbols, default, field_default),
Schema::Array(inner) => self.resolve_array(&inner.items, names,
enclosing_namespace),
Schema::Map(inner) => self.resolve_map(&inner.types, names,
enclosing_namespace),
- Schema::Record(RecordSchema { fields, .. }) => {
- self.resolve_record(fields, names, enclosing_namespace)
+ Schema::Record(RecordSchema { fields, name, .. }) => {
+ self.resolve_record(fields, names,
name.namespace().or(enclosing_namespace))
Review Comment:
It's not useful when used directly from `resolve_schemata` but
`resolve_internal` is a recursive function. So at some point in the recursion
there can be a Record which does not have its own namespace but has an
enclosing namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
