[
https://issues.apache.org/jira/browse/BEAM-5716?focusedWorklogId=155469&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155469
]
ASF GitHub Bot logged work on BEAM-5716:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/18 16:01
Start Date: 17/Oct/18 16:01
Worklog Time Spent: 10m
Work Description: lgajowy opened a new pull request #6725: [BEAM-5716]
Reorganize testing modules
URL: https://github.com/apache/beam/pull/6725
In this pr load-tests and Nexmark suites were gathered together in a
"testing" directory. Special "test-utils" module was divided to store common
code for those two (and possibly other tests, such as IOITs).
For now, only MetricsReader class was extracted to the common module to
diminish reviewer - contributor feedback loop. In the future, most of the
metrics related and publishing metrics related code (eg. to BigQuery) could be
moved to the common module. Nexmark is the most advanced in those areas so
other tests should benefit from that.
I added an extra commit that uses the common metrics class in load tests.
let me know if this should be moved from this pr.
💡 Friendly hint - it might be easier to review commit by commit.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 155469)
Time Spent: 10m
Remaining Estimate: 0h
> Move testing utilities to a common place
> ----------------------------------------
>
> Key: BEAM-5716
> URL: https://issues.apache.org/jira/browse/BEAM-5716
> Project: Beam
> Issue Type: Task
> Components: testing
> Reporter: Lukasz Gajowy
> Assignee: Lukasz Gajowy
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This was raised on the devlist here:
> [https://lists.apache.org/thread.html/19412a35c06d41b378c7e0116557b6eccbd7c289d86998e8ab3fadcf@%3Cdev.beam.apache.org%3E]
> Short version: there are some testing utilities from nexmark module that
> could be reused in load test (and possibly elsewhere). Other than that, both
> Nexmark and Load-tests should be stored in a common module together with the
> utils, as they all serve similar causes (testing).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
