[
https://issues.apache.org/jira/browse/BEAM-5716?focusedWorklogId=158781&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-158781
]
ASF GitHub Bot logged work on BEAM-5716:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Oct/18 17:13
Start Date: 25/Oct/18 17:13
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6725:
[BEAM-5716] Reorganize testing modules
URL: https://github.com/apache/beam/pull/6725#discussion_r228258808
##########
File path: settings.gradle
##########
@@ -161,19 +161,21 @@ project(":beam-sdks-java-io-synthetic").dir =
file("sdks/java/io/synthetic")
include "beam-sdks-java-javadoc"
project(":beam-sdks-java-javadoc").dir = file("sdks/java/javadoc")
include "beam-sdks-java-load-tests"
-project(":beam-sdks-java-load-tests").dir = file("sdks/java/load-tests")
+project(":beam-sdks-java-load-tests").dir =
file("sdks/java/testing/load-tests")
include "beam-sdks-java-maven-archetypes-examples"
project(":beam-sdks-java-maven-archetypes-examples").dir =
file("sdks/java/maven-archetypes/examples")
include "beam-sdks-java-maven-archetypes-starter"
project(":beam-sdks-java-maven-archetypes-starter").dir =
file("sdks/java/maven-archetypes/starter")
include "beam-sdks-java-nexmark"
-project(":beam-sdks-java-nexmark").dir = file("sdks/java/nexmark")
+project(":beam-sdks-java-nexmark").dir = file("sdks/java/testing/nexmark")
Review comment:
Please update the website as well fixing links for the new paths:
```
./website/src/_includes/section-menu/sdks.html:25: <li><a href="{{
site.baseurl }}/documentation/sdks/java/nexmark/">Nexmark benchmark
suite</a></li>
./website/src/documentation/sdks/nexmark.md:5:permalink:
/documentation/sdks/java/nexmark/
./website/src/documentation/sdks/nexmark.md:82:[NexmarkConfiguration.java](https://github.com/apache/beam/blob/master/sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkConfiguration.java)).
./website/src/documentation/sdks/nexmark.md:649:
sdks/java/nexmark/build/libs/beam-sdks-java-nexmark-{{ site.release_latest
}}-spark.jar \
./website/src/documentation/sdks/java.md:48:-
[Nexmark]({{site.baseurl}}/documentation/sdks/java/nexmark) is a benchmark
suite that runs in batch and streaming modes.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 158781)
> Move testing utilities to a common place
> ----------------------------------------
>
> Key: BEAM-5716
> URL: https://issues.apache.org/jira/browse/BEAM-5716
> Project: Beam
> Issue Type: Task
> Components: testing
> Reporter: Lukasz Gajowy
> Assignee: Lukasz Gajowy
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> This was raised on the devlist here:
> [https://lists.apache.org/thread.html/19412a35c06d41b378c7e0116557b6eccbd7c289d86998e8ab3fadcf@%3Cdev.beam.apache.org%3E]
> Short version: there are some testing utilities from nexmark module that
> could be reused in load test (and possibly elsewhere). Other than that, both
> Nexmark and Load-tests should be stored in a common module together with the
> utils, as they all serve similar causes (testing).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
