[
https://issues.apache.org/jira/browse/BEAM-5499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653794#comment-16653794
]
Scott Wegner commented on BEAM-5499:
------------------------------------
Makes sense to me. We could easily create a pre-commit RAT-only pre-commit that
runs on all changes, and then remove :rat from the language-specific precommits.
> Run :rat target on all file changes in Beam repo.
> -------------------------------------------------
>
> Key: BEAM-5499
> URL: https://issues.apache.org/jira/browse/BEAM-5499
> Project: Beam
> Issue Type: Test
> Components: testing
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
>
> Currently, when checking files to new folder not under any of SDK, we do not
> trigger automatic pre-commit.
> It might be not correct to run all languages pre-commits, but we should run
> :rat targets, since all files in repo should contain licence, etc.
> Additional benefit is that we avoid checked in files that didn't pass :ratÂ
> breaking post-commit tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
