[
https://issues.apache.org/jira/browse/BEAM-5730?focusedWorklogId=155498&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155498
]
ASF GitHub Bot logged work on BEAM-5730:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/18 16:45
Start Date: 17/Oct/18 16:45
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6694:
[BEAM-5730] Migrate ITs using DataflowRunner to use custom worker
URL: https://github.com/apache/beam/pull/6694#discussion_r226009082
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -104,12 +105,18 @@ test {
task validatesRunnerTest(type: Test) {
group = "Verification"
+ dependsOn ":beam-runners-google-cloud-dataflow-java-legacy-worker:shadowJar"
def dataflowProject = project.findProperty('dataflowProject') ?:
'apache-beam-testing'
def dataflowTempRoot = project.findProperty('dataflowTempRoot') ?:
'gs://temp-storage-for-validates-runner-tests/'
+ def dataflowWorkerJar = project.findProperty('dataflowWorkerJar') ?:
project(":beam-runners-google-cloud-dataflow-java-legacy-worker").shadowJar.archivePath
+
systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
"--runner=TestDataflowRunner",
"--project=${dataflowProject}",
"--tempRoot=${dataflowTempRoot}",
+ "--dataflowWorkerJar=${dataflowWorkerJar}",
+ "--workerHarnessContainerImage=",
Review comment:
Why do we leave a blank workerHarnessContainerImage?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 155498)
Time Spent: 50m (was: 40m)
> Migrate Java test to use a staged worker jar
> --------------------------------------------
>
> Key: BEAM-5730
> URL: https://issues.apache.org/jira/browse/BEAM-5730
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
