[
https://issues.apache.org/jira/browse/BEAM-5730?focusedWorklogId=155525&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155525
]
ASF GitHub Bot logged work on BEAM-5730:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/18 17:28
Start Date: 17/Oct/18 17:28
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #6694:
[BEAM-5730] Migrate ITs using DataflowRunner to use custom worker
URL: https://github.com/apache/beam/pull/6694#discussion_r226025275
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryToTableIT.java
##########
@@ -291,8 +292,10 @@ public void testStandardQueryWithoutCustom() throws
Exception {
@Test
public void testNewTypesQueryWithoutReshuffleWithCustom() throws Exception {
this.setupNewTypesQueryTest();
- this.options.setExperiments(
- ImmutableList.of("enable_custom_bigquery_sink",
"enable_custom_bigquery_source"));
+ List<String> experiments = new ArrayList<>();
+ experiments.add("enable_custom_bigquery_sink");
Review comment:
If there is dataflowWorkerJar set, then we will append the experiment flag
into experiments:
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java#L744.
In this case, if the experiments from pipeline is a immutable collection, then
when trying to append the worker_jar experiment, an exception will be thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 155525)
Time Spent: 1.5h (was: 1h 20m)
> Migrate Java test to use a staged worker jar
> --------------------------------------------
>
> Key: BEAM-5730
> URL: https://issues.apache.org/jira/browse/BEAM-5730
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
