[
https://issues.apache.org/jira/browse/BEAM-5760?focusedWorklogId=155599&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155599
]
ASF GitHub Bot logged work on BEAM-5760:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/18 20:46
Start Date: 17/Oct/18 20:46
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6723: [WIP]
[BEAM-5760] Add support for multi-element bundles to portable Flink runner.
URL: https://github.com/apache/beam/pull/6723#discussion_r226012199
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -159,49 +160,16 @@ private StateRequestHandler
getStateRequestHandler(ExecutableStage executableSta
}
}
- // TODO: currently assumes that every element is a separate bundle,
- // but this can be changed by pushing some of this logic into the
"DoFnRunner"
- private void processElementWithSdkHarness(WindowedValue<InputT> element)
throws Exception {
- checkState(
- stageBundleFactory != null, "%s not yet prepared",
StageBundleFactory.class.getName());
- checkState(
- stateRequestHandler != null, "%s not yet prepared",
StateRequestHandler.class.getName());
-
- OutputReceiverFactory receiverFactory =
- new OutputReceiverFactory() {
- @Override
- public FnDataReceiver<OutputT> create(String pCollectionId) {
- return (receivedElement) -> {
- // handover to queue, do not block the grpc thread
- outputQueue.put(KV.of(pCollectionId, receivedElement));
- };
- }
- };
-
- try (RemoteBundle bundle =
- stageBundleFactory.getBundle(receiverFactory, stateRequestHandler,
progressHandler)) {
- LOG.debug(String.format("Sending value: %s", element));
- // TODO(BEAM-4681): Add support to Flink to support portable timers.
-
Iterables.getOnlyElement(bundle.getInputReceivers().values()).accept(element);
- // TODO: it would be nice to emit results as they arrive, can thread
wait non-blocking?
- }
-
- // RemoteBundle close blocks until all results are received
- KV<String, OutputT> result;
- while ((result = outputQueue.poll()) != null) {
- outputManager.output(outputMap.get(result.getKey()), (WindowedValue)
result.getValue());
- }
- }
-
@Override
- public void close() throws Exception {
+ public void dispose() throws Exception {
Review comment:
Why do we use `dispose` instead of `close`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 155599)
Time Spent: 40m (was: 0.5h)
> Portable Flink support for maxBundleSize/maxBundleMillis
> --------------------------------------------------------
>
> Key: BEAM-5760
> URL: https://issues.apache.org/jira/browse/BEAM-5760
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Affects Versions: 2.8.0
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Labels: portability-flink
> Fix For: 2.9.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The portable runner needs to support larger bundles in streaming mode.
> Currently every element is a separate bundle, which is very inefficient due
> to the per bundle SDK worker overhead. The old Java SDK runner already
> supports these parameters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
