[
https://issues.apache.org/jira/browse/BEAM-5760?focusedWorklogId=155602&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155602
]
ASF GitHub Bot logged work on BEAM-5760:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/18 20:46
Start Date: 17/Oct/18 20:46
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6723: [WIP]
[BEAM-5760] Add support for multi-element bundles to portable Flink runner.
URL: https://github.com/apache/beam/pull/6723#discussion_r226084759
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -238,7 +230,19 @@ public void onTimer(
String timerId, BoundedWindow window, Instant timestamp, TimeDomain
timeDomain) {}
@Override
- public void finishBundle() {}
+ public void finishBundle() {
+ try {
+ // TODO: it would be nice to emit results as they arrive, can thread
wait non-blocking?
+ // RemoteBundle close blocks until all results are received
+ remoteBundle.close();
+ } catch (Exception e) {
+ throw new RuntimeException(e);
+ }
+ KV<String, OutputT> result;
+ while ((result = outputQueue.poll()) != null) {
+ outputManager.output(outputMap.get(result.getKey()), (WindowedValue)
result.getValue());
Review comment:
This will block forwarding the results until the bundle is finalized.
Depending on the bundle size, this could lead to memory pressure and increased
latency. Needs to be optimized (probably ok for now).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 155602)
Time Spent: 1h 10m (was: 1h)
> Portable Flink support for maxBundleSize/maxBundleMillis
> --------------------------------------------------------
>
> Key: BEAM-5760
> URL: https://issues.apache.org/jira/browse/BEAM-5760
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Affects Versions: 2.8.0
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Labels: portability-flink
> Fix For: 2.9.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The portable runner needs to support larger bundles in streaming mode.
> Currently every element is a separate bundle, which is very inefficient due
> to the per bundle SDK worker overhead. The old Java SDK runner already
> supports these parameters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
