[
https://issues.apache.org/jira/browse/BEAM-5745?focusedWorklogId=155786&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-155786
]
ASF GitHub Bot logged work on BEAM-5745:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Oct/18 09:13
Start Date: 18/Oct/18 09:13
Worklog Time Spent: 10m
Work Description: robertwb commented on issue #6687: [BEAM-5745] Fix
annotation test for py3
URL: https://github.com/apache/beam/pull/6687#issuecomment-430935698
Thanks for the detailed analysis, @tvalentyn . I agree both with your
assessment that we're just covering things up rather than finding the root
cause, and that we should reconsider the whole annotations system.
For the purpose of shipping a Python 3 compatible SDK, I propose that
resolving this double-printing is low priority and we simply relax this test
for Python 3 until all other kinks have been worked out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 155786)
Time Spent: 1.5h (was: 1h 20m)
> Util test on annotations fails
> -------------------------------
>
> Key: BEAM-5745
> URL: https://issues.apache.org/jira/browse/BEAM-5745
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Ruoyun Huang
> Assignee: Ruoyun Huang
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Traceback (most recent call last):
> File
> "/usr/local/google/home/ruoyun/projects/beam/sdks/python/apache_beam/utils/annotations_test.py",
> line 142, in test_frequency
> label_check_list=[])
> File
> "/usr/local/google/home/ruoyun/projects/beam/sdks/python/apache_beam/utils/annotations_test.py",
> line 149, in check_annotation
> self.assertIn(fnc_name + ' is ' + annotation_type,
> str(warning[-1].message))
> AssertionError: 'fnc2_test_annotate_frequency is experimental' not found in
> 'fnc_test_annotate_frequency is experimental.'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
