[
https://issues.apache.org/jira/browse/BEAM-5745?focusedWorklogId=156069&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-156069
]
ASF GitHub Bot logged work on BEAM-5745:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Oct/18 18:17
Start Date: 18/Oct/18 18:17
Worklog Time Spent: 10m
Work Description: HuangLED commented on issue #6687: [BEAM-5745] Fix
annotation test for py3
URL: https://github.com/apache/beam/pull/6687#issuecomment-431110744
Thanks Valentyn for sharing the research. Agree that we'd better rethink
the annotation machanism, which will require some dedicated efforts and beyond
the scope of this PR.
+1 to remove the line of simplefilter in py code.
Regarding the unit test. I vote for keeping the unit test and adding
simplefilter() in the test to counter act what is done by testing framework
(a.k.a. the options#2 I mentioned earlier) Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 156069)
Time Spent: 1h 50m (was: 1h 40m)
> Util test on annotations fails
> -------------------------------
>
> Key: BEAM-5745
> URL: https://issues.apache.org/jira/browse/BEAM-5745
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Ruoyun Huang
> Assignee: Ruoyun Huang
> Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Traceback (most recent call last):
> File
> "/usr/local/google/home/ruoyun/projects/beam/sdks/python/apache_beam/utils/annotations_test.py",
> line 142, in test_frequency
> label_check_list=[])
> File
> "/usr/local/google/home/ruoyun/projects/beam/sdks/python/apache_beam/utils/annotations_test.py",
> line 149, in check_annotation
> self.assertIn(fnc_name + ' is ' + annotation_type,
> str(warning[-1].message))
> AssertionError: 'fnc2_test_annotate_frequency is experimental' not found in
> 'fnc_test_annotate_frequency is experimental.'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
