[
https://issues.apache.org/jira/browse/BEAM-5829?focusedWorklogId=157345&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157345
]
ASF GitHub Bot logged work on BEAM-5829:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/18 04:19
Start Date: 23/Oct/18 04:19
Worklog Time Spent: 10m
Work Description: kennknowles opened a new pull request #6787:
[BEAM-5829] Convert tests to use DECIMAL for price field
URL: https://github.com/apache/beam/pull/6787
The Beam SQL tests of intersect, union, and set difference use a DOUBLE
field for a price. This is a bad practice. It also happened to interact badly
with a fix to `RowCoder` to make it consistent with `DoubleCoder` in #6772.
This PR just fixes the tests. The ultimate question of "what should be the
spec?" remains unresolved but it is clear from the examples online that
whatever the SQL standard says, equality on floating point numbers is not
reasonable to support in an abstract library like ours.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 157345)
Time Spent: 10m
Remaining Estimate: 0h
> SQL should probably not support GROUP BY or set operations on floating point
> numbers
> ------------------------------------------------------------------------------------
>
> Key: BEAM-5829
> URL: https://issues.apache.org/jira/browse/BEAM-5829
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Critical
> Time Spent: 10m
> Remaining Estimate: 0h
>
> These are known to be super unreliable on most SQL engines, and generally
> indicate a programming error. Floating points numbers are intended as
> stand-ins for real numbers, for which equality (hence grouping and set
> operations) are undecidable. And our build is broken because of it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
