[
https://issues.apache.org/jira/browse/BEAM-5829?focusedWorklogId=157599&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157599
]
ASF GitHub Bot logged work on BEAM-5829:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/18 15:23
Start Date: 23/Oct/18 15:23
Worklog Time Spent: 10m
Work Description: swegner closed pull request #6787: [BEAM-5829] Convert
tests to use DECIMAL for price field
URL: https://github.com/apache/beam/pull/6787
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamIntersectRelTest.java
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamIntersectRelTest.java
index 9ce389bdc33..72e8144f150 100644
---
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamIntersectRelTest.java
+++
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamIntersectRelTest.java
@@ -18,6 +18,7 @@
package org.apache.beam.sdk.extensions.sql.impl.rel;
+import java.math.BigDecimal;
import org.apache.beam.sdk.extensions.sql.TestUtils;
import org.apache.beam.sdk.extensions.sql.meta.provider.test.TestBoundedTable;
import org.apache.beam.sdk.schemas.Schema;
@@ -41,20 +42,41 @@ public static void prepare() {
TestBoundedTable.of(
Schema.FieldType.INT64, "order_id",
Schema.FieldType.INT32, "site_id",
- Schema.FieldType.DOUBLE, "price")
- .addRows(1L, 1, 1.0, 1L, 1, 1.0, 2L, 2, 2.0, 4L, 4, 4.0));
+ Schema.FieldType.DECIMAL, "price")
+ .addRows(
+ 1L,
+ 1,
+ new BigDecimal(1.0),
+ 1L,
+ 1,
+ new BigDecimal(1.0),
+ 2L,
+ 2,
+ new BigDecimal(2.0),
+ 4L,
+ 4,
+ new BigDecimal(4.0)));
registerTable(
"ORDER_DETAILS2",
TestBoundedTable.of(
Schema.FieldType.INT64, "order_id",
Schema.FieldType.INT32, "site_id",
- Schema.FieldType.DOUBLE, "price")
- .addRows(1L, 1, 1.0, 2L, 2, 2.0, 3L, 3, 3.0));
+ Schema.FieldType.DECIMAL, "price")
+ .addRows(
+ 1L,
+ 1,
+ new BigDecimal(1.0),
+ 2L,
+ 2,
+ new BigDecimal(2.0),
+ 3L,
+ 3,
+ new BigDecimal(3.0)));
}
@Test
- public void testIntersect() throws Exception {
+ public void testIntersect() {
String sql = "";
sql +=
"SELECT order_id, site_id, price "
@@ -69,15 +91,15 @@ public void testIntersect() throws Exception {
TestUtils.RowsBuilder.of(
Schema.FieldType.INT64, "order_id",
Schema.FieldType.INT32, "site_id",
- Schema.FieldType.DOUBLE, "price")
- .addRows(1L, 1, 1.0, 2L, 2, 2.0)
+ Schema.FieldType.DECIMAL, "price")
+ .addRows(1L, 1, new BigDecimal(1.0), 2L, 2, new
BigDecimal(2.0))
.getRows());
pipeline.run().waitUntilFinish();
}
@Test
- public void testIntersectAll() throws Exception {
+ public void testIntersectAll() {
String sql = "";
sql +=
"SELECT order_id, site_id, price "
@@ -94,8 +116,17 @@ public void testIntersectAll() throws Exception {
TestUtils.RowsBuilder.of(
Schema.FieldType.INT64, "order_id",
Schema.FieldType.INT32, "site_id",
- Schema.FieldType.DOUBLE, "price")
- .addRows(1L, 1, 1.0, 1L, 1, 1.0, 2L, 2, 2.0)
+ Schema.FieldType.DECIMAL, "price")
+ .addRows(
+ 1L,
+ 1,
+ new BigDecimal(1.0),
+ 1L,
+ 1,
+ new BigDecimal(1.0),
+ 2L,
+ 2,
+ new BigDecimal(2.0))
.getRows());
pipeline.run();
diff --git
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamMinusRelTest.java
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamMinusRelTest.java
index 02e84b98b47..20b0e63b524 100644
---
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamMinusRelTest.java
+++
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamMinusRelTest.java
@@ -18,6 +18,7 @@
package org.apache.beam.sdk.extensions.sql.impl.rel;
+import java.math.BigDecimal;
import org.apache.beam.sdk.extensions.sql.TestUtils;
import org.apache.beam.sdk.extensions.sql.meta.provider.test.TestBoundedTable;
import org.apache.beam.sdk.schemas.Schema;
@@ -40,16 +41,40 @@ public static void prepare() {
TestBoundedTable.of(
Schema.FieldType.INT64, "order_id",
Schema.FieldType.INT32, "site_id",
- Schema.FieldType.DOUBLE, "price")
- .addRows(1L, 1, 1.0, 1L, 1, 1.0, 2L, 2, 2.0, 4L, 4, 4.0, 4L, 4,
4.0));
+ Schema.FieldType.DECIMAL, "price")
+ .addRows(
+ 1L,
+ 1,
+ new BigDecimal(1.0),
+ 1L,
+ 1,
+ new BigDecimal(1.0),
+ 2L,
+ 2,
+ new BigDecimal(2.0),
+ 4L,
+ 4,
+ new BigDecimal(4.0),
+ 4L,
+ 4,
+ new BigDecimal(4.0)));
registerTable(
"ORDER_DETAILS2",
TestBoundedTable.of(
Schema.FieldType.INT64, "order_id",
Schema.FieldType.INT32, "site_id",
- Schema.FieldType.DOUBLE, "price")
- .addRows(1L, 1, 1.0, 2L, 2, 2.0, 3L, 3, 3.0));
+ Schema.FieldType.DECIMAL, "price")
+ .addRows(
+ 1L,
+ 1,
+ new BigDecimal(1.0),
+ 2L,
+ 2,
+ new BigDecimal(2.0),
+ 3L,
+ 3,
+ new BigDecimal(3.0)));
}
@Test
@@ -68,8 +93,8 @@ public void testExcept() throws Exception {
TestUtils.RowsBuilder.of(
Schema.FieldType.INT64, "order_id",
Schema.FieldType.INT32, "site_id",
- Schema.FieldType.DOUBLE, "price")
- .addRows(4L, 4, 4.0)
+ Schema.FieldType.DECIMAL, "price")
+ .addRows(4L, 4, new BigDecimal(4.0))
.getRows());
pipeline.run();
@@ -93,8 +118,8 @@ public void testExceptAll() throws Exception {
TestUtils.RowsBuilder.of(
Schema.FieldType.INT64, "order_id",
Schema.FieldType.INT32, "site_id",
- Schema.FieldType.DOUBLE, "price")
- .addRows(4L, 4, 4.0, 4L, 4, 4.0)
+ Schema.FieldType.DECIMAL, "price")
+ .addRows(4L, 4, new BigDecimal(4.0), 4L, 4, new
BigDecimal(4.0))
.getRows());
pipeline.run();
diff --git
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamUnionRelTest.java
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamUnionRelTest.java
index 63e63e87f14..55368ae6013 100644
---
a/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamUnionRelTest.java
+++
b/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamUnionRelTest.java
@@ -18,6 +18,7 @@
package org.apache.beam.sdk.extensions.sql.impl.rel;
+import java.math.BigDecimal;
import org.apache.beam.sdk.extensions.sql.TestUtils;
import org.apache.beam.sdk.extensions.sql.meta.provider.test.TestBoundedTable;
import org.apache.beam.sdk.schemas.Schema;
@@ -40,8 +41,8 @@ public static void prepare() {
TestBoundedTable.of(
Schema.FieldType.INT64, "order_id",
Schema.FieldType.INT32, "site_id",
- Schema.FieldType.DOUBLE, "price")
- .addRows(1L, 1, 1.0, 2L, 2, 2.0));
+ Schema.FieldType.DECIMAL, "price")
+ .addRows(1L, 1, new BigDecimal(1.0), 2L, 2, new BigDecimal(2.0)));
}
@Test
@@ -60,8 +61,8 @@ public void testUnion() throws Exception {
TestUtils.RowsBuilder.of(
Schema.FieldType.INT64, "order_id",
Schema.FieldType.INT32, "site_id",
- Schema.FieldType.DOUBLE, "price")
- .addRows(1L, 1, 1.0, 2L, 2, 2.0)
+ Schema.FieldType.DECIMAL, "price")
+ .addRows(1L, 1, new BigDecimal(1.0), 2L, 2, new
BigDecimal(2.0))
.getRows());
pipeline.run();
}
@@ -82,8 +83,20 @@ public void testUnionAll() throws Exception {
TestUtils.RowsBuilder.of(
Schema.FieldType.INT64, "order_id",
Schema.FieldType.INT32, "site_id",
- Schema.FieldType.DOUBLE, "price")
- .addRows(1L, 1, 1.0, 1L, 1, 1.0, 2L, 2, 2.0, 2L, 2, 2.0)
+ Schema.FieldType.DECIMAL, "price")
+ .addRows(
+ 1L,
+ 1,
+ new BigDecimal(1.0),
+ 1L,
+ 1,
+ new BigDecimal(1.0),
+ 2L,
+ 2,
+ new BigDecimal(2.0),
+ 2L,
+ 2,
+ new BigDecimal(2.0))
.getRows());
pipeline.run();
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 157599)
Time Spent: 40m (was: 0.5h)
> SQL should probably not support GROUP BY or set operations on floating point
> numbers
> ------------------------------------------------------------------------------------
>
> Key: BEAM-5829
> URL: https://issues.apache.org/jira/browse/BEAM-5829
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Critical
> Time Spent: 40m
> Remaining Estimate: 0h
>
> These are known to be super unreliable on most SQL engines, and generally
> indicate a programming error. Floating points numbers are intended as
> stand-ins for real numbers, for which equality (hence grouping and set
> operations) are undecidable. And our build is broken because of it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
