[
https://issues.apache.org/jira/browse/BEAM-4431?focusedWorklogId=158184&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-158184
]
ASF GitHub Bot logged work on BEAM-4431:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/18 15:23
Start Date: 24/Oct/18 15:23
Worklog Time Spent: 10m
Work Description: swegner commented on issue #6804: [BEAM-4431] Add "Edit
on Github" button to website
URL: https://github.com/apache/beam/pull/6804#issuecomment-432704308
Awesome!
I'll say that the icon isn't my favorite; to me it looks dated. Where did
you find it?
One alternative would be to use a standard icon from
[FontAwesome](https://github.com/FortAwesome/Font-Awesome), which is an
open-source icon library. Here's there [edit
icon](https://fontawesome.com/icons/edit?style=solid).
FontAwesome uses a [CC BY 4.0
License](https://github.com/FortAwesome/Font-Awesome/blob/master/LICENSE.txt),
which just requires attribution. There's [a
bunch](https://github.com/search?l=SCSS&q=http%3A%2F%2Ffontawesome.io%2Flicense+user%3Aapache&type=Code)
of Apache projects using it on their website; [here's a commit from Apache
Bookkeeper](https://github.com/apache/bookkeeper/commit/fdbea38d9767e6eb28fbf8ec7c61491be3e06e66#diff-580864d96f78430ef8afdc24e59edcae)
that looks to be very similar to how we might use it.
CC: @melap
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 158184)
Time Spent: 0.5h (was: 20m)
> Add "Edit this Page" button to website
> --------------------------------------
>
> Key: BEAM-4431
> URL: https://issues.apache.org/jira/browse/BEAM-4431
> Project: Beam
> Issue Type: New Feature
> Components: website
> Reporter: Scott Wegner
> Assignee: Alan Myrvold
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I found a [thread on the [email protected]
> list|https://lists.apache.org/thread.html/7c84f8bcdd086d119835c8dc0d995b2aaf642f43b70587d0dff3fa04@%3Cbuilds.apache.org%3E]
> where the Structs project mentions their "Edit on Github" website button.
> I've always thought this would be a nice addition to encourage readers to
> update documentation whenever they see something out-of-date. It sounds like
> it would be fairly easy to integrate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
