[
https://issues.apache.org/jira/browse/BEAM-3253?focusedWorklogId=159054&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159054
]
ASF GitHub Bot logged work on BEAM-3253:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/18 09:29
Start Date: 26/Oct/18 09:29
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #6692:
[BEAM-3253] Specify gradle dependencies for Python tox tasks.
URL: https://github.com/apache/beam/pull/6692#discussion_r228456769
##########
File path: sdks/python/build.gradle
##########
@@ -97,101 +97,63 @@ task depSnapshot(dependsOn: 'installGcpTest') {
}
}
-task lint {}
-check.dependsOn lint
-
-task lintPy27(dependsOn: 'setupVirtualenv') {
- doLast {
- exec {
- executable 'sh'
- args '-c', ". ${envdir}/bin/activate && tox ${tox_opts} -e py27-lint"
+def pythonSdkDeps = files(
+ fileTree(dir: 'apache_beam', includes: ['**/*.py', '**/*.pyx',
'**/*.pxd']),
+ fileTree(dir: 'apache_beam/testing/data'),
+ fileTree(dir: "${project.rootDir}/model"),
+ "MANIFEST.in",
+ "gen_protos.py",
+ "setup.cfg",
+ "setup.py",
+ "test_config.py",
+ "tox.ini")
+
+def toxTask = {
+ name, tox_env -> tasks.create(name) {
+ dependsOn = ['setupVirtualenv']
+ doLast {
+ exec {
+ executable 'sh'
+ args '-c', ". ${envdir}/bin/activate && tox ${tox_opts} -e $tox_env &&
touch ${outputs.files[0].path}"
Review comment:
We need an output for caching. Originally, I tee'd this command into this
file, but there's no good way to get `foo | tee` to return the exit code of
`foo`. However, using the default log (as noted below) should be good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 159054)
Time Spent: 1h (was: 50m)
> Gradle configurations do not declare correct inputs/outputs, requiring
> --rerun-tasks
> ------------------------------------------------------------------------------------
>
> Key: BEAM-3253
> URL: https://issues.apache.org/jira/browse/BEAM-3253
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Luke Cwik
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Support incremental builds by ensuring all tasks correctly specify their
> inputs and outputs.
> This is currently not correctly setup for any shell tasks and all code
> generation tasks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
