[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=159778&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159778
]
ASF GitHub Bot logged work on BEAM-5887:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Oct/18 22:52
Start Date: 28/Oct/18 22:52
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-433750070
First, this is clearly a bugfix whether or not it works (so only my second
commit is questionable). We shouldn't be writing unshaded artifacts to
classifiers that don't scream `unshaded`. Ultimately "unshaded" sort of means
"funky invalid artifact, use at your own risk".
Now, actually trying to verify: It is crude, but I ran `/gradlew
:beam-sdks-java-core:shadowTestJar :beam-sdks-java-core:packageTests` on master
and on this PR with `fswatch sdks/java/core/build | grep jar` in another shell.
`master`:
```
/Users/klk/GitHub/apache/beam/sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
/Users/klk/GitHub/apache/beam/sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
/Users/klk/GitHub/apache/beam/sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
```
This PR:
```
/Users/klk/GitHub/apache/beam/sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
/Users/klk/GitHub/apache/beam/sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests.jar
/Users/klk/GitHub/apache/beam/sdks/java/core/build/libs/beam-sdks-java-core-2.9.0-SNAPSHOT-tests-unshaded.jar
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 159778)
Time Spent: 40m (was: 0.5h)
> packageTests and shadowTestJar write the same file
> --------------------------------------------------
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
