[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=159781&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-159781
]
ASF GitHub Bot logged work on BEAM-5887:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Oct/18 23:58
Start Date: 28/Oct/18 23:58
Worklog Time Spent: 10m
Work Description: adude3141 commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-433754633
LGTM
@kennknowles
I can confirm that
a: The change in commit '53753c8' is the only change I did to get to the
improvements with incremental build (i.e. rebuilding time without any changes
cut to 50% on my machine)
b: after applying that change I was able to enable parallel build (excluding
python/go/website which still cause me headaches), whereas without that fix I m
required to disable parallel build by adding option '--no-parallel'
Of course, that's not a proper testing so should be seen as a hint to
improvement at best.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 159781)
Time Spent: 1h 10m (was: 1h)
> packageTests and shadowTestJar write the same file
> --------------------------------------------------
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
