[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160256&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160256
]
ASF GitHub Bot logged work on BEAM-5887:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/18 22:27
Start Date: 29/Oct/18 22:27
Worklog Time Spent: 10m
Work Description: adude3141 commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-434104379
Meanwhile I had a look into those failing tests.
Seemingly I was able to reproduce this failure locally, simply by executing
that test in a loop. Interestingly, it failed always at latest after the third
round.
AFAIU, this is a race condition on the thread calling verify [1] and the one
getting the captured value [2]. Obviously, the latter will fail if the first
did not complete yet.
To verify that observation, I added a countdown latch to ensure, thread_1
did finish the verification before accessing the value. With that change, that
(local) issue seemed to be fixed.
Feels unhealthy.
[1]
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/fn/control/RegisterAndProcessBundleOperationTest.java#L736-L737
[2]
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/fn/control/RegisterAndProcessBundleOperationTest.java#L666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 160256)
Time Spent: 4h 10m (was: 4h)
> packageTests and shadowTestJar write the same file
> --------------------------------------------------
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
