[
https://issues.apache.org/jira/browse/BEAM-5887?focusedWorklogId=160281&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160281
]
ASF GitHub Bot logged work on BEAM-5887:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Oct/18 22:42
Start Date: 29/Oct/18 22:42
Worklog Time Spent: 10m
Work Description: adude3141 commented on issue #6864: [BEAM-5887] Fix
classifier for unshaded tests jars
URL: https://github.com/apache/beam/pull/6864#issuecomment-434107788
Well, that testclass already uses countdown latch here [1] or here [2],
which seem to solve similar issues.
Not sure, whether I like it, though. But, as I do not have any insights on
the code under test, I might just be a bit scared :)
[1]
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/fn/control/RegisterAndProcessBundleOperationTest.java#L248
[2]
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/fn/control/RegisterAndProcessBundleOperationTest.java#L751
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 160281)
Time Spent: 4.5h (was: 4h 20m)
> packageTests and shadowTestJar write the same file
> --------------------------------------------------
>
> Key: BEAM-5887
> URL: https://issues.apache.org/jira/browse/BEAM-5887
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Pointed out by [~michel], we should be packaging unshaded tests to e.g.
> {{tests-unshaded}} classifier. This is likely the root cause of BEAM-5035,
> BEAM-5116, BEAM-5207.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
