[
https://issues.apache.org/jira/browse/BEAM-5922?focusedWorklogId=160766&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-160766
]
ASF GitHub Bot logged work on BEAM-5922:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/18 18:46
Start Date: 30/Oct/18 18:46
Worklog Time Spent: 10m
Work Description: jklukas opened a new pull request #6892: [BEAM-5922]
Refactor Map, FlatMap, and Filter on MapperBase
URL: https://github.com/apache/beam/pull/6892
There should be no change in functionality or public interface with this
change.
The intention is to reduce code duplication between these three classes for
better consistency in future changes.
In particular, this change will simplify the implementation of failure
handling
across these transforms in https://issues.apache.org/jira/browse/BEAM-5638
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 160766)
Time Spent: 10m
Remaining Estimate: 0h
> Common base class for FlatMapElements, MapElements, and Filter
> --------------------------------------------------------------
>
> Key: BEAM-5922
> URL: https://issues.apache.org/jira/browse/BEAM-5922
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Jeff Klukas
> Assignee: Jeff Klukas
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> By having FlatMapElements, MapElements, and Filter all inherit from a common
> MapperBase, we can reduce code duplication between these three classes for
> better consistency in future changes. There should be no change in
> functionality or public interface with this change.
> In particular, this change will simplify the implementation of failure
> handling
> across these transforms in https://issues.apache.org/jira/browse/BEAM-5638
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
