[
https://issues.apache.org/jira/browse/BEAM-5919?focusedWorklogId=161264&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-161264
]
ASF GitHub Bot logged work on BEAM-5919:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Oct/18 18:23
Start Date: 31/Oct/18 18:23
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6889:
[BEAM-5919] Exclude META-INF from validation of shaded jar files
URL: https://github.com/apache/beam/pull/6889#discussion_r229815832
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -802,6 +802,7 @@ class BeamModulePlugin implements Plugin<Project> {
project.configurations.shadow.artifacts.files.each {
FileTree exposedClasses = project.zipTree(it).matching {
include "**/*.class"
+ exclude "META-INF/**" // BEAM-5919: Exclude module-info.class
for Java 9 build support
Review comment:
We currently are excluding everything under META-INF/
Are you suggesting that I make the exclude more restrictive by changing it
to be:
```
exclude "META-INF/versions/**/module-info.class"
exclude "META-INF/versions/**/org/apache/beam/**"
```
or to just update the comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 161264)
Time Spent: 1h 10m (was: 1h)
> Build breaks when including Multi-release Jars
> ----------------------------------------------
>
> Key: BEAM-5919
> URL: https://issues.apache.org/jira/browse/BEAM-5919
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Affects Versions: 2.8.0
> Reporter: Ismaël Mejía
> Assignee: Luke Cwik
> Priority: Minor
> Attachments: logjava9jarissue.txt
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> As part of BEAM-5891 there is a reported problem in the build system with
> jars that contain multiple versions of the classes (this is a feature
> introduced in Java 9). This should not be a problem when the main classes are
> still Java 8 compatible as it is the case for byte buddy.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
