[
https://issues.apache.org/jira/browse/BEAM-5919?focusedWorklogId=161365&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-161365
]
ASF GitHub Bot logged work on BEAM-5919:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Oct/18 22:41
Start Date: 31/Oct/18 22:41
Worklog Time Spent: 10m
Work Description: iemejia closed pull request #6889: [BEAM-5919] Exclude
META-INF from validation of shaded jar files
URL: https://github.com/apache/beam/pull/6889
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index edeafb73703..dd98a279b65 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -803,6 +803,9 @@ class BeamModulePlugin implements Plugin<Project> {
FileTree exposedClasses = project.zipTree(it).matching {
include "**/*.class"
exclude "org/apache/beam/**"
+ // BEAM-5919: Exclude paths for Java 9 multi-release jars.
+ exclude "META-INF/versions/*/module-info.class"
+ exclude "META-INF/versions/*/org/apache/beam/**"
}
if (exposedClasses.files) {
throw new GradleException("$it exposed classes outside of
org.apache.beam namespace: ${exposedClasses.files}")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 161365)
Time Spent: 1h 50m (was: 1h 40m)
> Build breaks when including Multi-release Jars
> ----------------------------------------------
>
> Key: BEAM-5919
> URL: https://issues.apache.org/jira/browse/BEAM-5919
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Affects Versions: 2.8.0
> Reporter: Ismaël Mejía
> Assignee: Luke Cwik
> Priority: Minor
> Attachments: logjava9jarissue.txt
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> As part of BEAM-5891 there is a reported problem in the build system with
> jars that contain multiple versions of the classes (this is a feature
> introduced in Java 9). This should not be a problem when the main classes are
> still Java 8 compatible as it is the case for byte buddy.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
