[
https://issues.apache.org/jira/browse/BEAM-3253?focusedWorklogId=161775&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-161775
]
ASF GitHub Bot logged work on BEAM-3253:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/18 22:56
Start Date: 01/Nov/18 22:56
Worklog Time Spent: 10m
Work Description: swegner closed pull request #6917: [BEAM-3253] enable
up-to-date checks for shaded jar validation tasks
URL: https://github.com/apache/beam/pull/6917
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index f3df98b26c8..1ba1ff797e7 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -803,7 +803,9 @@ class BeamModulePlugin implements Plugin<Project> {
if (configuration.validateShadowJar) {
project.task('validateShadedJarDoesntLeakNonOrgApacheBeamClasses',
dependsOn: 'shadowJar') {
+ ext.outFile = project.file("${project.reportsDir}/${name}.out")
inputs.files project.configurations.shadow.artifacts.files
+ outputs.files outFile
doLast {
project.configurations.shadow.artifacts.files.each {
FileTree exposedClasses = project.zipTree(it).matching {
@@ -813,6 +815,7 @@ class BeamModulePlugin implements Plugin<Project> {
exclude "META-INF/versions/*/module-info.class"
exclude "META-INF/versions/*/org/apache/beam/**"
}
+ outFile.text = exposedClasses.files
if (exposedClasses.files) {
throw new GradleException("$it exposed classes outside of
org.apache.beam namespace: ${exposedClasses.files}")
}
@@ -1502,10 +1505,13 @@ artifactId=${project.name}
}
project.task('validateShadedJarDoesntExportVendoredDependencies',
dependsOn: 'shadowJar') {
+ ext.outFile = project.file("${project.reportsDir}/${name}.out")
inputs.files project.configurations.shadow.artifacts.files
+ outputs.files outFile
doLast {
project.configurations.shadow.artifacts.files.each {
FileTree exportedClasses = project.zipTree(it).matching { include
"org/apache/beam/vendor/**" }
+ outFile.text = exportedClasses.files
if (exportedClasses.files) {
throw new GradleException("$it exported classes inside of
org.apache.beam.vendor namespace: ${exportedClasses.files}")
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 161775)
Time Spent: 3h 10m (was: 3h)
> Gradle configurations do not declare correct inputs/outputs, requiring
> --rerun-tasks
> ------------------------------------------------------------------------------------
>
> Key: BEAM-3253
> URL: https://issues.apache.org/jira/browse/BEAM-3253
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Luke Cwik
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Support incremental builds by ensuring all tasks correctly specify their
> inputs and outputs.
> This is currently not correctly setup for any shell tasks and all code
> generation tasks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
