[
https://issues.apache.org/jira/browse/BEAM-3253?focusedWorklogId=162110&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-162110
]
ASF GitHub Bot logged work on BEAM-3253:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Nov/18 21:33
Start Date: 02/Nov/18 21:33
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #6926: [BEAM-3253] Swap to
use local variable instead of using 'ext'
URL: https://github.com/apache/beam/pull/6926
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index 1ba1ff797e7..1b12553a4a0 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -803,7 +803,7 @@ class BeamModulePlugin implements Plugin<Project> {
if (configuration.validateShadowJar) {
project.task('validateShadedJarDoesntLeakNonOrgApacheBeamClasses',
dependsOn: 'shadowJar') {
- ext.outFile = project.file("${project.reportsDir}/${name}.out")
+ def outFile = project.file("${project.reportsDir}/${name}.out")
inputs.files project.configurations.shadow.artifacts.files
outputs.files outFile
doLast {
@@ -1505,7 +1505,7 @@ artifactId=${project.name}
}
project.task('validateShadedJarDoesntExportVendoredDependencies',
dependsOn: 'shadowJar') {
- ext.outFile = project.file("${project.reportsDir}/${name}.out")
+ def outFile = project.file("${project.reportsDir}/${name}.out")
inputs.files project.configurations.shadow.artifacts.files
outputs.files outFile
doLast {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 162110)
Time Spent: 5.5h (was: 5h 20m)
> Gradle configurations do not declare correct inputs/outputs, requiring
> --rerun-tasks
> ------------------------------------------------------------------------------------
>
> Key: BEAM-3253
> URL: https://issues.apache.org/jira/browse/BEAM-3253
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Luke Cwik
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Support incremental builds by ensuring all tasks correctly specify their
> inputs and outputs.
> This is currently not correctly setup for any shell tasks and all code
> generation tasks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
