[ 
https://issues.apache.org/jira/browse/BEAM-3253?focusedWorklogId=162315&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-162315
 ]

ASF GitHub Bot logged work on BEAM-3253:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Nov/18 10:31
            Start Date: 04/Nov/18 10:31
    Worklog Time Spent: 10m 
      Work Description: adude3141 commented on issue #6926: [BEAM-3253] Swap to 
use local variable instead of using 'ext'
URL: https://github.com/apache/beam/pull/6926#issuecomment-435658288
 
 
   Honestly, I just thought outFile to have the proper semantics to justify a 
task property.
   
   But of course your right, that it currently provides not much value, 
especially as that property must be treated as readonly.
   
   For instance, one might to try to do a
   `project.validateShadedJarDoesntLeakNonOrgApacheBeamClasses.outFile = 
project.file('shoutOutHere')
   println project.validateShadedJarDoesntLeakNonOrgApacheBeamClasses.outFile`
   which unfortunately will not work. I should have implemented an lazy setting 
as `outputs.files { outFile }` instead of directly setting `outputs.files 
outFile`
   
   But I guess, this does not matter as no one will ever try to overwrite the 
output file anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 162315)
    Time Spent: 5h 40m  (was: 5.5h)

> Gradle configurations do not declare correct inputs/outputs, requiring 
> --rerun-tasks
> ------------------------------------------------------------------------------------
>
>                 Key: BEAM-3253
>                 URL: https://issues.apache.org/jira/browse/BEAM-3253
>             Project: Beam
>          Issue Type: Sub-task
>          Components: build-system
>            Reporter: Luke Cwik
>            Priority: Major
>          Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> Support incremental builds by ensuring all tasks correctly specify their 
> inputs and outputs.
> This is currently not correctly setup for any shell tasks and all code 
> generation tasks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to