[
https://issues.apache.org/jira/browse/BEAM-5976?focusedWorklogId=162753&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-162753
]
ASF GitHub Bot logged work on BEAM-5976:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/18 21:10
Start Date: 05/Nov/18 21:10
Worklog Time Spent: 10m
Work Description: XuMingmin closed pull request #6950: [BEAM-5976] use
AbstractInstant as DATEITME type in functions
URL: https://github.com/apache/beam/pull/6950
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/operator/BeamSqlPrimitive.java
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/operator/BeamSqlPrimitive.java
index 3e442fe7c11..5ead358925d 100644
---
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/operator/BeamSqlPrimitive.java
+++
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/operator/BeamSqlPrimitive.java
@@ -28,6 +28,7 @@
import org.apache.calcite.sql.type.SqlTypeName;
import org.apache.calcite.util.NlsString;
import org.joda.time.ReadableInstant;
+import org.joda.time.base.AbstractInstant;
/**
* {@link BeamSqlPrimitive} is a special, self-reference {@link
BeamSqlExpression}. It holds the
@@ -137,7 +138,7 @@ public boolean accept() {
case TIME:
case TIMESTAMP:
case DATE:
- return value instanceof ReadableInstant;
+ return value instanceof AbstractInstant;
case INTERVAL_SECOND:
case INTERVAL_MINUTE:
case INTERVAL_HOUR:
diff --git
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/CalciteUtils.java
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/CalciteUtils.java
index 96ad251b36b..cd93166d2c7 100644
---
a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/CalciteUtils.java
+++
b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/CalciteUtils.java
@@ -30,7 +30,7 @@
import org.apache.calcite.rel.type.RelDataTypeFactory;
import org.apache.calcite.rel.type.RelDataTypeField;
import org.apache.calcite.sql.type.SqlTypeName;
-import org.joda.time.ReadableInstant;
+import org.joda.time.base.AbstractInstant;
/** Utility methods for Calcite related operations. */
public class CalciteUtils {
@@ -195,14 +195,14 @@ private static RelDataType toRelDataType(
/**
* SQL-Java type mapping, with specified Beam rules: <br>
- * 1. redirect {@link ReadableInstant} to {@link Date} so Calcite can
recognize it.
+ * 1. redirect {@link AbstractInstant} to {@link Date} so Calcite can
recognize it.
*
* @param rawType
* @return
*/
public static RelDataType sqlTypeWithAutoCast(RelDataTypeFactory
typeFactory, Type rawType) {
//For Joda time types, return SQL type for java.util.Date.
- if (rawType instanceof Class &&
ReadableInstant.class.isAssignableFrom((Class<?>) rawType)) {
+ if (rawType instanceof Class &&
AbstractInstant.class.isAssignableFrom((Class<?>) rawType)) {
return typeFactory.createJavaType(Date.class);
}
return typeFactory.createJavaType((Class) rawType);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 162753)
Time Spent: 50m (was: 40m)
> use AbstractInstant as DATEITME type in functions
> -------------------------------------------------
>
> Key: BEAM-5976
> URL: https://issues.apache.org/jira/browse/BEAM-5976
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Xu Mingmin
> Assignee: Xu Mingmin
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> refer to discussion in
> [https://github.com/apache/beam/pull/6913#discussion_r230148526]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
