[
https://issues.apache.org/jira/browse/BEAM-5976?focusedWorklogId=162897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-162897
]
ASF GitHub Bot logged work on BEAM-5976:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/18 05:07
Start Date: 06/Nov/18 05:07
Worklog Time Spent: 10m
Work Description: amaliujia edited a comment on issue #6950: [BEAM-5976]
use AbstractInstant as DATEITME type in functions
URL: https://github.com/apache/beam/pull/6950#issuecomment-436041510
Actually I think Row always returns ` ReadableDateTime`
([Row.java#L169)](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/Row.java#L169)).
Row does accepts `AbstractInstant` as input:
https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/Row.java#L611
So will the `ReadableDateTime` be most precise for SQL function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 162897)
Time Spent: 1h 10m (was: 1h)
> use AbstractInstant as DATEITME type in functions
> -------------------------------------------------
>
> Key: BEAM-5976
> URL: https://issues.apache.org/jira/browse/BEAM-5976
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Xu Mingmin
> Assignee: Xu Mingmin
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> refer to discussion in
> [https://github.com/apache/beam/pull/6913#discussion_r230148526]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
