[
https://issues.apache.org/jira/browse/BEAM-5971?focusedWorklogId=163162&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-163162
]
ASF GitHub Bot logged work on BEAM-5971:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/18 19:05
Start Date: 06/Nov/18 19:05
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #6946:
[BEAM-5971] Prevent unwanted shutdown of UnboundedSourceWrapper
URL: https://github.com/apache/beam/pull/6946#discussion_r231249468
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/io/UnboundedSourceWrapper.java
##########
@@ -281,6 +278,10 @@ public void
run(SourceContext<WindowedValue<ValueWithRecordId<OutputT>>> ctx) th
ctx.emitWatermark(new Watermark(Long.MAX_VALUE));
+ finalizeSource();
+ }
+
+ private void finalizeSource() {
Review comment:
'While' inside this method was never executed earlier as isRunning was
always false when we reached here.
Shall we call this method only from the 1st if statement L205 as even not,
in the other else blocks will exit only after isRunning is false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 163162)
Time Spent: 20m (was: 10m)
> Checkpointing fails for UnboundedSourceWrapper with no local Readers
> --------------------------------------------------------------------
>
> Key: BEAM-5971
> URL: https://issues.apache.org/jira/browse/BEAM-5971
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Fix For: 2.9.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> A parallel instance of {{UnboundedSourcewrapper}} may not receive local
> readers, in which it exits immediately. This prevents checkpointing due to
> FLINK-2491.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
