[
https://issues.apache.org/jira/browse/BEAM-5971?focusedWorklogId=163164&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-163164
]
ASF GitHub Bot logged work on BEAM-5971:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/18 19:10
Start Date: 06/Nov/18 19:10
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6946:
[BEAM-5971] Prevent unwanted shutdown of UnboundedSourceWrapper
URL: https://github.com/apache/beam/pull/6946#discussion_r231253736
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/io/UnboundedSourceWrapper.java
##########
@@ -281,6 +278,10 @@ public void
run(SourceContext<WindowedValue<ValueWithRecordId<OutputT>>> ctx) th
ctx.emitWatermark(new Watermark(Long.MAX_VALUE));
+ finalizeSource();
+ }
+
+ private void finalizeSource() {
Review comment:
Yes, the bug was that the finalize code was never executed for empty readers.
> Shall we call this method only from the 1st if statement L205 as even not,
in the other else blocks will exit only after isRunning is false.
All `if` blocks will eventually execute `finalizeSource`, so I wouldn't call
it directly in line 205 because that would additionally require a `return;`
statement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 163164)
Time Spent: 0.5h (was: 20m)
> Checkpointing fails for UnboundedSourceWrapper with no local Readers
> --------------------------------------------------------------------
>
> Key: BEAM-5971
> URL: https://issues.apache.org/jira/browse/BEAM-5971
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Fix For: 2.9.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> A parallel instance of {{UnboundedSourcewrapper}} may not receive local
> readers, in which it exits immediately. This prevents checkpointing due to
> FLINK-2491.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
