[ 
https://issues.apache.org/jira/browse/BEAM-5778?focusedWorklogId=163862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-163862
 ]

ASF GitHub Bot logged work on BEAM-5778:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Nov/18 11:13
            Start Date: 08/Nov/18 11:13
    Worklog Time Spent: 10m 
      Work Description: lgajowy commented on a change in pull request #6943: 
[BEAM-5778] Add integrations of Metrics API to Big Query for SyntheticcSources 
load tests in Python SDK
URL: https://github.com/apache/beam/pull/6943#discussion_r231848836
 
 

 ##########
 File path: sdks/python/apache_beam/testing/load_tests/co_group_by_key_test.py
 ##########
 @@ -18,7 +18,9 @@
 To run test on DirectRunner
 
 python setup.py nosetests \
-    --test-pipeline-options="--input_options='{
+    --test-pipeline-options="
+      --metrics_project_id=big-query-project
 
 Review comment:
   I think it's better to have one option for this, if possible. I don't think 
using multiple google cloud project will be ever needed. Even if so, then 
adding a new, big query specific pipeline option will be easy. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 163862)
    Time Spent: 3h 20m  (was: 3h 10m)

> Add integrations of Metrics API to Big Query for SyntheticSources load tests 
> in Python SDK
> ------------------------------------------------------------------------------------------
>
>                 Key: BEAM-5778
>                 URL: https://issues.apache.org/jira/browse/BEAM-5778
>             Project: Beam
>          Issue Type: Improvement
>          Components: testing
>            Reporter: Kasia Kucharczyk
>            Assignee: Kasia Kucharczyk
>            Priority: Major
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> Right now Metrics API collects basic metrics of load tests of 
> SyntheticSources (Python SDK). It should be collected in BigQuery for 
> presenting it on performance dashboards.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to