[
https://issues.apache.org/jira/browse/BEAM-3612?focusedWorklogId=164594&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-164594
]
ASF GitHub Bot logged work on BEAM-3612:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Nov/18 01:00
Start Date: 10/Nov/18 01:00
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #7000:
[BEAM-3612] Add a shim generator tool
URL: https://github.com/apache/beam/pull/7000#discussion_r232433271
##########
File path: sdks/go/cmd/starcgen/starcgen.go
##########
@@ -57,6 +57,13 @@ func Generate(w io.Writer, filename, pkg string, ids
[]string, fset *token.FileS
e.Print("*/\n")
data := e.Generate(filename)
+ if err := write(w, []byte(license)); err != nil {
+ return err
Review comment:
In principle: probably not.
In practice: the RAT check will likely complain if we don't, when trying to
check in the files.
Note: We need to check in the files, since the design of `go generate`
requires it be invoked manually, and the results are intended to be checked in.
Go says: `go generate` is for library authors, not library users.
Similarly, the protos are generated code, but we need to check in their
results. (They don't have the license though, but they may pre-date the RAT
check).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 164594)
Time Spent: 4.5h (was: 4h 20m)
> Make it easy to generate type-specialized Go SDK reflectx.Funcs
> ---------------------------------------------------------------
>
> Key: BEAM-3612
> URL: https://issues.apache.org/jira/browse/BEAM-3612
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
