[
https://issues.apache.org/jira/browse/BEAM-3612?focusedWorklogId=165043&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165043
]
ASF GitHub Bot logged work on BEAM-3612:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/18 18:03
Start Date: 12/Nov/18 18:03
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #7000:
[BEAM-3612] Add a shim generator tool
URL: https://github.com/apache/beam/pull/7000#discussion_r232758345
##########
File path: sdks/go/cmd/starcgen/starcgen.go
##########
@@ -57,6 +57,13 @@ func Generate(w io.Writer, filename, pkg string, ids
[]string, fset *token.FileS
e.Print("*/\n")
data := e.Generate(filename)
+ if err := write(w, []byte(license)); err != nil {
+ return err
Review comment:
Ack. But this is strange for the end users of the tool. They do not
necessarily need to want to use a this license.
Perhaps a TODO for the future to see if we can resolve this with the RAT
tool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 165043)
Time Spent: 6h 10m (was: 6h)
> Make it easy to generate type-specialized Go SDK reflectx.Funcs
> ---------------------------------------------------------------
>
> Key: BEAM-3612
> URL: https://issues.apache.org/jira/browse/BEAM-3612
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
