[
https://issues.apache.org/jira/browse/BEAM-3612?focusedWorklogId=165063&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165063
]
ASF GitHub Bot logged work on BEAM-3612:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/18 19:09
Start Date: 12/Nov/18 19:09
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #7000:
[BEAM-3612] Add a shim generator tool
URL: https://github.com/apache/beam/pull/7000#discussion_r232777857
##########
File path: sdks/go/cmd/starcgen/starcgen.go
##########
@@ -57,6 +57,13 @@ func Generate(w io.Writer, filename, pkg string, ids
[]string, fset *token.FileS
e.Print("*/\n")
data := e.Generate(filename)
+ if err := write(w, []byte(license)); err != nil {
+ return err
Review comment:
Given it's an Apache tool generating the code, it's not a huge stretch that
it should include the Apache license.
And a user that takes particular umbrage can always use the starcgenx
package to write their own tooling to generate the code.
I would happily accept a patch (or spend the 2 minutes necessary to write
the code) to flag the license inclusion lines, if a user requested it. I'd
rather not speculate on possible usecases, and generalizing/flagging before
there's a concrete need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 165063)
Time Spent: 6.5h (was: 6h 20m)
> Make it easy to generate type-specialized Go SDK reflectx.Funcs
> ---------------------------------------------------------------
>
> Key: BEAM-3612
> URL: https://issues.apache.org/jira/browse/BEAM-3612
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
