[
https://issues.apache.org/jira/browse/BEAM-6054?focusedWorklogId=165395&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165395
]
ASF GitHub Bot logged work on BEAM-6054:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/18 12:19
Start Date: 13/Nov/18 12:19
Worklog Time Spent: 10m
Work Description: dmvk commented on a change in pull request #7019:
[BEAM-6054] Euphoria translation providers refactored.
URL: https://github.com/apache/beam/pull/7019#discussion_r233014303
##########
File path:
sdks/java/extensions/euphoria/src/main/java/org/apache/beam/sdk/extensions/euphoria/core/translate/provider/GenericTranslatorProvider.java
##########
@@ -0,0 +1,246 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.euphoria.core.translate.provider;
+
+import static java.util.Objects.requireNonNull;
+
+import com.google.common.base.Preconditions;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Optional;
+import java.util.function.Predicate;
+import
org.apache.beam.sdk.extensions.euphoria.core.client.operator.CompositeOperator;
+import org.apache.beam.sdk.extensions.euphoria.core.client.operator.FlatMap;
+import org.apache.beam.sdk.extensions.euphoria.core.client.operator.Join;
+import
org.apache.beam.sdk.extensions.euphoria.core.client.operator.ReduceByKey;
+import org.apache.beam.sdk.extensions.euphoria.core.client.operator.Union;
+import
org.apache.beam.sdk.extensions.euphoria.core.client.operator.base.Operator;
+import
org.apache.beam.sdk.extensions.euphoria.core.translate.CompositeOperatorTranslator;
+import
org.apache.beam.sdk.extensions.euphoria.core.translate.FlatMapTranslator;
+import org.apache.beam.sdk.extensions.euphoria.core.translate.JoinTranslator;
+import
org.apache.beam.sdk.extensions.euphoria.core.translate.OperatorTranslator;
+import
org.apache.beam.sdk.extensions.euphoria.core.translate.ReduceByKeyTranslator;
+import
org.apache.beam.sdk.extensions.euphoria.core.translate.TranslatorProvider;
+import org.apache.beam.sdk.extensions.euphoria.core.translate.UnionTranslator;
+
+/**
+ * Adjustable {@link TranslatorProvider} that selects first suitable
translation for the registered
+ * operator.
+ *
+ * <p>{@link OperatorTranslator Translators} can be added by calling variants
of {@link
+ * GenericTranslatorProvider.Builder#register(Class, OperatorTranslator)
register} method during
+ * build. Order of registration is important. Building is started by {@link
#newBuilder()}.
+ */
+public class GenericTranslatorProvider implements TranslatorProvider {
+
+ private final List<TranslationDescriptor> possibleTranslators;
+
+ private GenericTranslatorProvider(List<TranslationDescriptor>
possibleTranslators) {
+ this.possibleTranslators = possibleTranslators;
+ }
+
+ public static GenericTranslatorProvider createWithDefaultTranslators() {
+ return GenericTranslatorProvider.newBuilder()
+ .register(FlatMap.class, new FlatMapTranslator<>())
+ .register(Union.class, new UnionTranslator<>())
+ .register(ReduceByKey.class, new ReduceByKeyTranslator<>())
+ .register(Join.class, new JoinTranslator<>())
+ // register fallback operator translator to decompose composit
operators
+ .register(op -> op instanceof CompositeOperator, new
CompositeOperatorTranslator<>())
Review comment:
I still have a feeling that CompositeOperator deserves its own provider, and
the GenericTranslatorProvider would allow to register translators for specific
operators only.
But I don't have any strong argument for this :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 165395)
Time Spent: 50m (was: 40m)
> Refactor traslator providers
> -----------------------------
>
> Key: BEAM-6054
> URL: https://issues.apache.org/jira/browse/BEAM-6054
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-euphoria
> Reporter: Vaclav Plajt
> Assignee: Vaclav Plajt
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We need following functionality:
> 1. Way of registering translator providers for operator type with optional
> user-defined predicate
> 1. Way of registering translator providers for any operator based on
> predicate. (e.g `CompositeOperatorTranslator`)
> 1. Way of chaining translator providers
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
