[
https://issues.apache.org/jira/browse/BEAM-6028?focusedWorklogId=165941&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-165941
]
ASF GitHub Bot logged work on BEAM-6028:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/18 16:02
Start Date: 14/Nov/18 16:02
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #6993:
[BEAM-6028] Share docker image name along with shared task
URL: https://github.com/apache/beam/pull/6993#discussion_r233509340
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -115,7 +115,13 @@ def dataflowFnApiWorkerJar =
project.findProperty('dataflowWorkerJar') ?: projec
def dockerImageRoot = project.findProperty('dockerImageRoot') ?:
"us.gcr.io/${dataflowProject}/java-postcommit-it"
def dockerImageContainer = "${dockerImageRoot}/java"
def dockerTag = new Date().format('yyyyMMddHHmmss')
-def dockerImageName = "${dockerImageContainer}:${dockerTag}"
+ext.dockerImageName = "${dockerImageContainer}:${dockerTag}"
Review comment:
With this refactoring, both test suites (precommit, postcommit) share a
single `buildAndPushDockerContainer` task, so if both test suites were to
execute together, `buildAndPushDockerContainer` would only be executed once and
the containers re-used for both suites. I believe this is preferable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 165941)
Time Spent: 3h (was: 2h 50m)
> beam_PreCommit_JavaPortabilityApi_Cron fails due to a timeout
> -------------------------------------------------------------
>
> Key: BEAM-6028
> URL: https://issues.apache.org/jira/browse/BEAM-6028
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-harness
> Affects Versions: Not applicable
> Reporter: Chamikara Jayalath
> Assignee: Scott Wegner
> Priority: Critical
> Attachments: 1.png
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Looks like last three runs failed (so probably perma red).
>
> For example,
> [https://builds.apache.org/job/beam_PreCommit_JavaPortabilityApi_Cron/26/]
> [https://builds.apache.org/job/beam_PreCommit_JavaPortabilityApi_Cron/26/console]
>
> Scott, looks like this first failed for your following commit. But not 100%
> sure if this is the reason.
> [https://github.com/apache/beam/commit/42984a821b3e73aee2966d11d7fb436b5ff22b68]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
