[
https://issues.apache.org/jira/browse/BEAM-6028?focusedWorklogId=166047&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166047
]
ASF GitHub Bot logged work on BEAM-6028:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/18 19:30
Start Date: 14/Nov/18 19:30
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #6993:
[BEAM-6028] Share docker image name along with shared task
URL: https://github.com/apache/beam/pull/6993#discussion_r233588391
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -115,7 +115,13 @@ def dataflowFnApiWorkerJar =
project.findProperty('dataflowWorkerJar') ?: projec
def dockerImageRoot = project.findProperty('dockerImageRoot') ?:
"us.gcr.io/${dataflowProject}/java-postcommit-it"
def dockerImageContainer = "${dockerImageRoot}/java"
def dockerTag = new Date().format('yyyyMMddHHmmss')
-def dockerImageName = "${dockerImageContainer}:${dockerTag}"
+ext.dockerImageName = "${dockerImageContainer}:${dockerTag}"
Review comment:
Valid point. The `buildAndPushDockerContainer` task will only run once per
gradle execution task graph, so if a single jenkins job ran both pre-commits
and post-commits they would share a single container image on gcr. But you're
right that concurrent builds from different jenkins machines could possibly
overwrite each other.
The current tag scheme includes a timestamp up to second precision, so a
collision is possible but unlikely. This risk of races between concurrent
builds is an existing possibility even without this change.
Do you think we need to address it with this PR or can it be deferred?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 166047)
Time Spent: 3.5h (was: 3h 20m)
> beam_PreCommit_JavaPortabilityApi_Cron fails due to a timeout
> -------------------------------------------------------------
>
> Key: BEAM-6028
> URL: https://issues.apache.org/jira/browse/BEAM-6028
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-harness
> Affects Versions: Not applicable
> Reporter: Chamikara Jayalath
> Assignee: Scott Wegner
> Priority: Critical
> Attachments: 1.png
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Looks like last three runs failed (so probably perma red).
>
> For example,
> [https://builds.apache.org/job/beam_PreCommit_JavaPortabilityApi_Cron/26/]
> [https://builds.apache.org/job/beam_PreCommit_JavaPortabilityApi_Cron/26/console]
>
> Scott, looks like this first failed for your following commit. But not 100%
> sure if this is the reason.
> [https://github.com/apache/beam/commit/42984a821b3e73aee2966d11d7fb436b5ff22b68]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
