[
https://issues.apache.org/jira/browse/BEAM-6073?focusedWorklogId=166998&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166998
]
ASF GitHub Bot logged work on BEAM-6073:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Nov/18 18:36
Start Date: 16/Nov/18 18:36
Worklog Time Spent: 10m
Work Description: swegner closed pull request #7070: [BEAM-6073] Update
README with lockfile & gradle instructions
URL: https://github.com/apache/beam/pull/7070
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/go/README.md b/sdks/go/README.md
index 50e9456c083..ce824000bce 100644
--- a/sdks/go/README.md
+++ b/sdks/go/README.md
@@ -149,3 +149,23 @@ $ go test ./...
If you don’t have a GOPATH set, create a new directory in your home directory,
and use that.
Follow the [contribution
guide](https://beam.apache.org/contribute/contribution-guide/#code) to create
branches, and submit pull requests as normal.
+
+### Dependency management
+Until [BEAM-5379](https://issues.apache.org/jira/browse/BEAM-5379) is resolved,
+Beam locks versions of packages with the gogradle plugin. If new dependencies
+are added in a PR then the lock file needs to be updated.
+From the `$GOPATH/src/github.com/apache/beam` directory run
+
+```
+$ ./gradlew :beam-sdks-go:lock
+`./gradlew :goPostcommit`
+```
+
+ to update the lock file, and test your code under the locked versions.
gogradle
+will add vendor directories with the locked versions of the code.
+
+You can sanity check a PR on Jenkins by commenting `Run Go PostCommit` to
trigger
+the integration tests. This is important so that the Beam testing done on the
+jenkins cluster can produce consistent results, and have the packages
available.
+
+
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 166998)
Time Spent: 2h (was: 1h 50m)
> Go PostCommit Broken -> gogradle needs "github.com/stretchr/testify/assert"
> dep.
> --------------------------------------------------------------------------------
>
> Key: BEAM-6073
> URL: https://issues.apache.org/jira/browse/BEAM-6073
> Project: Beam
> Issue Type: Bug
> Components: sdk-go, test-failures
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> [https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/1676/]
> 16:41:13 ok github.com/apache/beam/sdks/go/pkg/beam/artifact 0.047s coverage:
> 68.5% of statements
> 16:41:14 # github.com/apache/beam/sdks/go/pkg/beam/io/databaseio
> 16:41:14
> .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/pkg/beam/io/databaseio/util_test.go:21:2:
> cannot find package "github.com/stretchr/testify/assert" in any of:
> 16:41:14
> /home/jenkins/jenkins-slave/workspace/beam_PostCommit_Go_GradleBuild/src/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/stretchr/testify/assert
> (vendor tree)
> 16:41:14
> /home/jenkins/.gradle/go/binary/1.10/go/src/github.com/stretchr/testify/assert
> (from $GOROOT)
> 16:41:14
> /home/jenkins/jenkins-slave/workspace/beam_PostCommit_Go_GradleBuild/src/sdks/go/.gogradle/project_gopath/src/github.com/stretchr/testify/assert
> (from $GOPATH)
> 16:41:14 FAIL github.com/apache/beam/sdks/go/pkg/beam/io/databaseio [setup
> failed]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
