[
https://issues.apache.org/jira/browse/BEAM-6073?focusedWorklogId=167137&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-167137
]
ASF GitHub Bot logged work on BEAM-6073:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Nov/18 00:39
Start Date: 17/Nov/18 00:39
Worklog Time Spent: 10m
Work Description: lostluck closed pull request #7057: [BEAM-6073] Update
go lock file & README.md
URL: https://github.com/apache/beam/pull/7057
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/go/README.md b/sdks/go/README.md
index 50e9456c083..6dfcd62380d 100644
--- a/sdks/go/README.md
+++ b/sdks/go/README.md
@@ -149,3 +149,24 @@ $ go test ./...
If you don’t have a GOPATH set, create a new directory in your home directory,
and use that.
Follow the [contribution
guide](https://beam.apache.org/contribute/contribution-guide/#code) to create
branches, and submit pull requests as normal.
+
+### Dependency management
+
+Until [BEAM-5379](https://issues.apache.org/jira/browse/BEAM-5379) is resolved,
+ Beam locks versions of packages with the gogradle plugin. If new dependencies
+are added in a PR then the lock file needs to be updated.
+
+From the `$GOPATH/src/github.com/apache/beam` directory run
+
+```
+$ ./gradlew :beam-sdks-go:lock
+$ ./gradlew :beam-sdks-go:test
+```
+
+to update the lock file, and test your code under the locked versions. gogradle
+will add vendor directories with the locked versions of the code.
+
+You can sanity check a PR by commenting `Run Go PostCommit` to trigger them.
+
+This is important so that the Beam testing done on the jenkins cluster can
+produce consistent results, and have the packagesavailable.
\ No newline at end of file
diff --git a/sdks/go/gogradle.lock b/sdks/go/gogradle.lock
index 9ab419c4a8b..3f901af0819 100644
--- a/sdks/go/gogradle.lock
+++ b/sdks/go/gogradle.lock
@@ -1,6 +1,6 @@
# This file is generated by gogradle automatically, you should NEVER modify it
manually.
---
-apiVersion: "0.8.1"
+apiVersion: "0.10"
dependencies:
build:
- vcs: "git"
@@ -694,4 +694,41 @@ dependencies:
vcs: "git"
vendorPath: "vendor/gopkg.in/yaml.v2"
transitive: false
- test: []
+ test:
+ - name: "github.com/davecgh/go-spew"
+ host:
+ name: "github.com/stretchr/testify"
+ commit: "04af85275a5c7ac09d16bb3b9b2e751ed45154e5"
+ urls:
+ - "https://github.com/stretchr/testify.git";
+ - "[email protected]:stretchr/testify.git"
+ vcs: "git"
+ vendorPath: "vendor/github.com/davecgh/go-spew"
+ transitive: false
+ - name: "github.com/pmezard/go-difflib"
+ host:
+ name: "github.com/stretchr/testify"
+ commit: "04af85275a5c7ac09d16bb3b9b2e751ed45154e5"
+ urls:
+ - "https://github.com/stretchr/testify.git";
+ - "[email protected]:stretchr/testify.git"
+ vcs: "git"
+ vendorPath: "vendor/github.com/pmezard/go-difflib"
+ transitive: false
+ - name: "github.com/stretchr/objx"
+ host:
+ name: "github.com/stretchr/testify"
+ commit: "04af85275a5c7ac09d16bb3b9b2e751ed45154e5"
+ urls:
+ - "https://github.com/stretchr/testify.git";
+ - "[email protected]:stretchr/testify.git"
+ vcs: "git"
+ vendorPath: "vendor/github.com/stretchr/objx"
+ transitive: false
+ - urls:
+ - "https://github.com/stretchr/testify.git";
+ - "[email protected]:stretchr/testify.git"
+ vcs: "git"
+ name: "github.com/stretchr/testify"
+ commit: "04af85275a5c7ac09d16bb3b9b2e751ed45154e5"
+ transitive: false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 167137)
Time Spent: 2.5h (was: 2h 20m)
> Go PostCommit Broken -> gogradle needs "github.com/stretchr/testify/assert"
> dep.
> --------------------------------------------------------------------------------
>
> Key: BEAM-6073
> URL: https://issues.apache.org/jira/browse/BEAM-6073
> Project: Beam
> Issue Type: Bug
> Components: sdk-go, test-failures
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> [https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/1676/]
> 16:41:13 ok github.com/apache/beam/sdks/go/pkg/beam/artifact 0.047s coverage:
> 68.5% of statements
> 16:41:14 # github.com/apache/beam/sdks/go/pkg/beam/io/databaseio
> 16:41:14
> .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/pkg/beam/io/databaseio/util_test.go:21:2:
> cannot find package "github.com/stretchr/testify/assert" in any of:
> 16:41:14
> /home/jenkins/jenkins-slave/workspace/beam_PostCommit_Go_GradleBuild/src/sdks/go/.gogradle/project_gopath/src/github.com/apache/beam/sdks/go/vendor/github.com/stretchr/testify/assert
> (vendor tree)
> 16:41:14
> /home/jenkins/.gradle/go/binary/1.10/go/src/github.com/stretchr/testify/assert
> (from $GOROOT)
> 16:41:14
> /home/jenkins/jenkins-slave/workspace/beam_PostCommit_Go_GradleBuild/src/sdks/go/.gogradle/project_gopath/src/github.com/stretchr/testify/assert
> (from $GOPATH)
> 16:41:14 FAIL github.com/apache/beam/sdks/go/pkg/beam/io/databaseio [setup
> failed]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
