[ 
https://issues.apache.org/jira/browse/BEAM-4444?focusedWorklogId=167587&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-167587
 ]

ASF GitHub Bot logged work on BEAM-4444:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Nov/18 01:17
            Start Date: 20/Nov/18 01:17
    Worklog Time Spent: 10m 
      Work Description: udim commented on a change in pull request #6763: 
[BEAM-4444] Parquet IO for Python SDK
URL: https://github.com/apache/beam/pull/6763#discussion_r234829253
 
 

 ##########
 File path: sdks/python/apache_beam/io/parquetio_test.py
 ##########
 @@ -268,6 +296,78 @@ def test_sink_transform_snappy(self):
             | Map(json.dumps)
         assert_that(readback, equal_to([json.dumps(r) for r in self.RECORDS]))
 
+  def test_sink_transform_gzip(self):
+    with tempfile.NamedTemporaryFile() as dst:
+      path = dst.name
+      with TestPipeline() as p:
+        # pylint: disable=expression-not-assigned
+        p \
+        | Create(self.RECORDS) \
+        | WriteToParquet(
+            path, self.SCHEMA, codec='gzip',
 
 Review comment:
   These tests look identical except for the codec used.
   Could you make `codec` a parameter?
   See example here: 
https://github.com/apache/beam/blob/1cbbc4d8755130f137e7d9ef4813e8d3b917cb70/sdks/python/apache_beam/io/filesystem_test.py#L230

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 167587)

> Parquet IO for Python SDK
> -------------------------
>
>                 Key: BEAM-4444
>                 URL: https://issues.apache.org/jira/browse/BEAM-4444
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-py-core
>            Reporter: Bruce Arctor
>            Assignee: Heejong Lee
>            Priority: Major
>          Time Spent: 10h 20m
>  Remaining Estimate: 0h
>
> Add Parquet Support for the Python SDK.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to