[
https://issues.apache.org/jira/browse/BEAM-4444?focusedWorklogId=167581&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-167581
]
ASF GitHub Bot logged work on BEAM-4444:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/18 01:17
Start Date: 20/Nov/18 01:17
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #6763:
[BEAM-4444] Parquet IO for Python SDK
URL: https://github.com/apache/beam/pull/6763#discussion_r234825587
##########
File path: sdks/python/apache_beam/io/parquetio_test.py
##########
@@ -219,20 +233,34 @@ def test_write_display_data(self):
write = WriteToParquet(file_name, self.SCHEMA)
dd = DisplayData.create_from(write)
expected_items = [
+ DisplayDataItemMatcher(
+ 'codec',
+ 'none'),
DisplayDataItemMatcher(
'schema',
str(self.SCHEMA)),
+ DisplayDataItemMatcher(
+ 'row_group_buffer_size',
+ str(64*1024*1024)),
DisplayDataItemMatcher(
'file_pattern',
'some_parquet_sink-%(shard_num)05d-of-%(num_shards)05d'),
- DisplayDataItemMatcher(
- 'codec',
- 'none'),
DisplayDataItemMatcher(
'compression',
'uncompressed')]
hc.assert_that(dd.items, hc.contains_inanyorder(*expected_items))
+ def test_sink_transform_int96(self):
+ with tempfile.NamedTemporaryFile() as dst:
+ path = dst.name
+ with self.assertRaises(ArrowInvalid):
+ with TestPipeline() as p:
+ # pylint: disable=expression-not-assigned
Review comment:
This directive affects all lines below it until EOF. It should be followed
by a corresponding '`enable`'.
Please do a search as there are multiple `# pylint:` directives in this PR.
Alternatively, I would assign to underscore:
```
_ = p \
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 167581)
Time Spent: 10h (was: 9h 50m)
> Parquet IO for Python SDK
> -------------------------
>
> Key: BEAM-4444
> URL: https://issues.apache.org/jira/browse/BEAM-4444
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Bruce Arctor
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 10h
> Remaining Estimate: 0h
>
> Add Parquet Support for the Python SDK.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)