[
https://issues.apache.org/jira/browse/BEAM-6116?focusedWorklogId=168901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-168901
]
ASF GitHub Bot logged work on BEAM-6116:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/18 18:39
Start Date: 22/Nov/18 18:39
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #7124:
[BEAM-6116] [portable flink streaming] Emit pushed back watermark when bundle
is complete
URL: https://github.com/apache/beam/pull/7124#discussion_r235802806
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -398,7 +396,10 @@ public void processWatermark(Watermark mark) throws
Exception {
sdkHarnessRunner.setBundleFinishedCallback(
() -> {
try {
- processWatermark(mark);
+ LOG.debug("processing pushed back watermark: {}", mark);
+ // at this point the bundle is finished, allow the watermark
to pass
+ setPushedBackWatermark(mark.getTimestamp());
Review comment:
What if there was already a hold > mark?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 168901)
Time Spent: 50m (was: 40m)
> Pushed back watermark never emitted in portable Flink runner
> ------------------------------------------------------------
>
> Key: BEAM-6116
> URL: https://issues.apache.org/jira/browse/BEAM-6116
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Affects Versions: 2.9.0
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Critical
> Labels: portability-flink
> Fix For: 2.9.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The portable runner pushes back the watermark while the bundle processes in
> the SDK worker. After the bundle is complete, that watermark needs to be
> emitted. That never happens, because ExecutableStageDoFnOperator does not
> clear the hold.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
