[
https://issues.apache.org/jira/browse/BEAM-6116?focusedWorklogId=168917&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-168917
]
ASF GitHub Bot logged work on BEAM-6116:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/18 19:34
Start Date: 22/Nov/18 19:34
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #7124:
[BEAM-6116] [portable flink streaming] Emit pushed back watermark when bundle
is complete
URL: https://github.com/apache/beam/pull/7124#discussion_r235808559
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -394,11 +392,16 @@ public void processWatermark(Watermark mark) throws
Exception {
} else {
// It is not safe to advance the output watermark yet, so add a hold
on the current
// output watermark.
- setPushedBackWatermark(Math.min(currentOutputWatermark,
getPushbackWatermarkHold()));
+ long previousHold = getPushbackWatermarkHold();
Review comment:
This still doesn't work because multiple watermarks arriving before bundle
completes will wipe out the previous hold.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 168917)
Time Spent: 1.5h (was: 1h 20m)
> Pushed back watermark never emitted in portable Flink runner
> ------------------------------------------------------------
>
> Key: BEAM-6116
> URL: https://issues.apache.org/jira/browse/BEAM-6116
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Affects Versions: 2.9.0
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Critical
> Labels: portability-flink
> Fix For: 2.9.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The portable runner pushes back the watermark while the bundle processes in
> the SDK worker. After the bundle is complete, that watermark needs to be
> emitted. That never happens, because ExecutableStageDoFnOperator does not
> clear the hold.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
