[
https://issues.apache.org/jira/browse/BEAM-6122?focusedWorklogId=169481&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-169481
]
ASF GitHub Bot logged work on BEAM-6122:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/18 20:38
Start Date: 26/Nov/18 20:38
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#7129: [BEAM-6122] Update committer guidelines
URL: https://github.com/apache/beam/pull/7129#discussion_r236415789
##########
File path: website/src/contribute/index.md
##########
@@ -149,9 +149,11 @@ To contribute code, you need
have an open source license
[compatible](https://www.apache.org/legal/resolved.html#criteria) with Apache.
1. Add unit tests for your change
1. When your change is ready to be reviewed and merged, create a pull request.
- Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`,
+ Format commit messages and the pull request title like `[BEAM-XXX] Fixes
bug in ApproximateQuantiles`,
Review comment:
I think some time ago we had a line that was something like "for trivial
changes this is not necessary", when the rule applied only to pull requests. Is
that line deleted? Just checking. I am actually fine having it deleted. I think
that someone should be very involved in the project enough to have appropriate
judgment about when it might be overkill.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 169481)
Time Spent: 1h 40m (was: 1.5h)
> Update committer guidelines
> ---------------------------
>
> Key: BEAM-6122
> URL: https://issues.apache.org/jira/browse/BEAM-6122
> Project: Beam
> Issue Type: Task
> Components: website
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Per discussion in
> [https://lists.apache.org/thread.html/6d922820d6fc352479f88e5c8737f2c8893ddb706a1e578b50d28948@%3Cdev.beam.apache.org%3E]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
