[
https://issues.apache.org/jira/browse/BEAM-6122?focusedWorklogId=169486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-169486
]
ASF GitHub Bot logged work on BEAM-6122:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/18 20:40
Start Date: 26/Nov/18 20:40
Worklog Time Spent: 10m
Work Description: amaliujia commented on a change in pull request #7129:
[BEAM-6122] Update committer guidelines
URL: https://github.com/apache/beam/pull/7129#discussion_r236417459
##########
File path: website/src/contribute/committer-guide.md
##########
@@ -100,3 +128,6 @@ Instead, pull it all into the subject line:
Merge pull request #1234: [BEAM-7873] Fix the foo bizzle bazzle
If you have comments to add, put them in the body of the commit message.
+
+After merging the pull request, the committer is responsible for resolving
associated JIRA(s)
Review comment:
It's a trade off between full context of a JIRA and a well managed JIRA task
list. Contributors could have more context on a JIRA but contributors could
leave the JIRA open unintentionally.
A compromise could be that committer asks in a JIRA if it can be closed
after associated PR is approved, and close the JIRA if no reply shows up within
a reasonable time (like 3 days). Contributor could always reopen the JIRA or
add more context later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 169486)
Time Spent: 2h (was: 1h 50m)
> Update committer guidelines
> ---------------------------
>
> Key: BEAM-6122
> URL: https://issues.apache.org/jira/browse/BEAM-6122
> Project: Beam
> Issue Type: Task
> Components: website
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Per discussion in
> [https://lists.apache.org/thread.html/6d922820d6fc352479f88e5c8737f2c8893ddb706a1e578b50d28948@%3Cdev.beam.apache.org%3E]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
