[ https://issues.apache.org/jira/browse/BEAM-6122?focusedWorklogId=169534&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-169534 ]
ASF GitHub Bot logged work on BEAM-6122: ---------------------------------------- Author: ASF GitHub Bot Created on: 26/Nov/18 22:43 Start Date: 26/Nov/18 22:43 Worklog Time Spent: 10m Work Description: tweise commented on a change in pull request #7129: [BEAM-6122] Update committer guidelines URL: https://github.com/apache/beam/pull/7129#discussion_r236457055 ########## File path: website/src/contribute/committer-guide.md ########## @@ -100,3 +128,6 @@ Instead, pull it all into the subject line: Merge pull request #1234: [BEAM-7873] Fix the foo bizzle bazzle If you have comments to add, put them in the body of the commit message. + +After merging the pull request, the committer is responsible for resolving associated JIRA(s) Review comment: We should move this line out of the PR and discuss it separately. To review a PR, I probably need to sufficiently understand the scope of the JIRA and what the change I just merge addresses or not. Typically the committer merging the PR takes the last action in the chain and the contributor may not return just to close out the JIRA. The committer is also more likely to be aware of the versioning. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 169534) Time Spent: 3.5h (was: 3h 20m) > Update committer guidelines > --------------------------- > > Key: BEAM-6122 > URL: https://issues.apache.org/jira/browse/BEAM-6122 > Project: Beam > Issue Type: Task > Components: website > Reporter: Thomas Weise > Assignee: Thomas Weise > Priority: Major > Time Spent: 3.5h > Remaining Estimate: 0h > > Per discussion in > [https://lists.apache.org/thread.html/6d922820d6fc352479f88e5c8737f2c8893ddb706a1e578b50d28948@%3Cdev.beam.apache.org%3E] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)