[
https://issues.apache.org/jira/browse/BEAM-5850?focusedWorklogId=170885&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-170885
]
ASF GitHub Bot logged work on BEAM-5850:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/18 23:55
Start Date: 29/Nov/18 23:55
Worklog Time Spent: 10m
Work Description: Ardagan commented on a change in pull request #6786:
[BEAM-5850] Add QueueingBeamFnDataClient and make process, finish and start run
on the same thread to support metrics.
URL: https://github.com/apache/beam/pull/6786#discussion_r237691911
##########
File path:
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/RemoteExecutionTest.java
##########
@@ -278,6 +279,91 @@ public void process(ProcessContext ctxt) {
}
}
+ @Test
+ public void testBundleExecutionFailure() throws Exception {
+ Pipeline p = Pipeline.create();
+ p.apply("impulse", Impulse.create())
+ .apply(
+ "create",
+ ParDo.of(
+ new DoFn<byte[], KV<String, String>>() {
+ @ProcessElement
+ public void process(ProcessContext ctxt) throws Exception {
+ String element =
+ CoderUtils.decodeFromByteArray(StringUtf8Coder.of(),
ctxt.element());
+ if (element.equals("X")) {
+ throw new Exception("testBundleExecutionFailure");
+ }
+ ctxt.output(KV.of(element, element));
+ }
+ }))
+ .apply("gbk", GroupByKey.create());
+
+ RunnerApi.Pipeline pipelineProto = PipelineTranslation.toProto(p);
Review comment:
[No action comment]
Do I understand correctly that you build bundle to process?
If it is, it might be useful to extract such code to share between tests. I
might reuse it in some other places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 170885)
Time Spent: 12.5h (was: 12h 20m)
> Make process, finish and start run on the same thread to support metrics.
> -------------------------------------------------------------------------
>
> Key: BEAM-5850
> URL: https://issues.apache.org/jira/browse/BEAM-5850
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution
> Reporter: Alex Amato
> Assignee: Alex Amato
> Priority: Major
> Time Spent: 12.5h
> Remaining Estimate: 0h
>
> Update BeamFnDataReceiver to place elements into a Queue and consumer then
> and call the element processing receiver in blockTillReadFinishes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
