[
https://issues.apache.org/jira/browse/BEAM-5850?focusedWorklogId=170884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-170884
]
ASF GitHub Bot logged work on BEAM-5850:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/18 23:55
Start Date: 29/Nov/18 23:55
Worklog Time Spent: 10m
Work Description: Ardagan commented on a change in pull request #6786:
[BEAM-5850] Add QueueingBeamFnDataClient and make process, finish and start run
on the same thread to support metrics.
URL: https://github.com/apache/beam/pull/6786#discussion_r237691054
##########
File path:
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/RemoteExecutionTest.java
##########
@@ -278,6 +279,91 @@ public void process(ProcessContext ctxt) {
}
}
+ @Test
+ public void testBundleExecutionFailure() throws Exception {
Review comment:
Using test names in the form of
<someone><does_something><when_something_happens> usually makes tests more
readable with additional benefit of:
1. Defines expected behavior
2. Simplifies triaging of test failure to the level when reading test name
might be enough.
3. Surves as inline test description.
I suggest renaming this to
"testBundleProcessorThrowsExecutionExceptionWhenUserCodeThrows"
This applies to other tests names as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 170884)
Time Spent: 12h 20m (was: 12h 10m)
> Make process, finish and start run on the same thread to support metrics.
> -------------------------------------------------------------------------
>
> Key: BEAM-5850
> URL: https://issues.apache.org/jira/browse/BEAM-5850
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution
> Reporter: Alex Amato
> Assignee: Alex Amato
> Priority: Major
> Time Spent: 12h 20m
> Remaining Estimate: 0h
>
> Update BeamFnDataReceiver to place elements into a Queue and consumer then
> and call the element processing receiver in blockTillReadFinishes
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
