[
https://issues.apache.org/jira/browse/BEAM-6160?focusedWorklogId=171279&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-171279
]
ASF GitHub Bot logged work on BEAM-6160:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Dec/18 04:57
Start Date: 01/Dec/18 04:57
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #7168:
[BEAM-6160] Use service server rather than service
URL: https://github.com/apache/beam/pull/7168#discussion_r238052145
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/ServerFactory.java
##########
@@ -72,6 +73,14 @@ public abstract Server allocatePortAndCreate(
public abstract Server create(
BindableService service, Endpoints.ApiServiceDescriptor
serviceDescriptor) throws IOException;
+ /**
+ * Creates an instance of this server at the address specified by the given
service descriptor and
+ * binded by multi services. Server applies {@link
Review comment:
`binded by multi services` -> `bound to multiple services`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 171279)
Time Spent: 40m (was: 0.5h)
> Simplify service and server creation in dataflow runner harness
> ---------------------------------------------------------------
>
> Key: BEAM-6160
> URL: https://issues.apache.org/jira/browse/BEAM-6160
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
