[
https://issues.apache.org/jira/browse/BEAM-6160?focusedWorklogId=171701&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-171701
]
ASF GitHub Bot logged work on BEAM-6160:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/18 20:22
Start Date: 03/Dec/18 20:22
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #7168:
[BEAM-6160] Use service server rather than service
URL: https://github.com/apache/beam/pull/7168#discussion_r238419493
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/GrpcFnServer.java
##########
@@ -43,12 +44,50 @@
*/
public static <ServiceT extends FnService> GrpcFnServer<ServiceT> create(
ServiceT service, ApiServiceDescriptor endpoint, ServerFactory factory)
throws IOException {
- return new GrpcFnServer<>(factory.create(service, endpoint), service,
endpoint);
+ return new GrpcFnServer<>(
+ factory.create(ImmutableList.of(service), endpoint), service,
endpoint);
}
+ /** @deprecated This create function is used for Dataflow migration purpose
only. */
+ @Deprecated
public static <ServiceT extends FnService> GrpcFnServer<ServiceT> create(
ServiceT service, ApiServiceDescriptor endpoint) {
- return new GrpcFnServer<>(null, service, endpoint);
+ Server fakeServer =
Review comment:
I was thinking you would create an anonymous subclass of GrpcFnServer, not
of the gRPC Server class where calling close does nothing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 171701)
Time Spent: 2h 10m (was: 2h)
> Simplify service and server creation in dataflow runner harness
> ---------------------------------------------------------------
>
> Key: BEAM-6160
> URL: https://issues.apache.org/jira/browse/BEAM-6160
> Project: Beam
> Issue Type: Sub-task
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
