[
https://issues.apache.org/jira/browse/BEAM-1628?focusedWorklogId=171660&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-171660
]
ASF GitHub Bot logged work on BEAM-1628:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/18 17:27
Start Date: 03/Dec/18 17:27
Worklog Time Spent: 10m
Work Description: mxm opened a new pull request #7187: [BEAM-1628] Allow
empty port for flink master url
URL: https://github.com/apache/beam/pull/7187
This allows only specifying the host name without a port. It reads the port
from
the configuration or uses the default Flink port if non configured. It does
not
fall back to the special "[auto]" mode anymore if the port is omitted.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 171660)
Time Spent: 10m
Remaining Estimate: 0h
> Flink runner: logic around --flinkMaster is error-prone
> -------------------------------------------------------
>
> Key: BEAM-1628
> URL: https://issues.apache.org/jira/browse/BEAM-1628
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Davor Bonaci
> Assignee: Maximilian Michels
> Priority: Minor
> Labels: newbie, starter
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The logic for handling {{--flinkMaster}} seems not particularly user-friendly.
> https://github.com/apache/beam/blob/fbcde4cdc7d68de8734bf540c079b2747631a854/runners/flink/runner/src/main/java/org/apache/beam/runners/flink/FlinkPipelineExecutionEnvironment.java#L132
> {code}
> if (masterUrl.equals("[local]")) {
> } else if (masterUrl.equals("[collection]")) {
> } else if (masterUrl.equals("[auto]")) {
> } else if (masterUrl.matches(".*:\\d*")) {
> } else {
> // use auto.
> }
> {code}
> The options are constructed with "auto" set as default.
> I think we should do the following:
> * I assume there's a default port for the Flink master. We should default to
> it.
> * We should treat a string without a colon as a host name. (Not default to
> local execution.)
> This is super easy fix, hopefully someone can pick it up quickly ;-)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
